HidemaruOwO/puyoskey
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

clarify naming of legacy rate limit methods

Browse source
This commit is contained in:
Hazelnoot 2024-12-11 14:07:25 -05:00
parent 72d18602d8
commit 755ff8783b
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/backend/src/server/api/SkRateLimiterService.ts
View file

@ -55,15 +55,15 @@ export class SkRateLimiterService {
private async limitLegacy(limit: Keyed<LegacyRateLimit>, actor: string, factor: number): Promise<LimitInfo> { private async limitLegacy(limit: Keyed<LegacyRateLimit>, actor: string, factor: number): Promise<LimitInfo> {
if (hasMaxLimit(limit)) { if (hasMaxLimit(limit)) {
return await this.limitMaxLegacy(limit, actor, factor); return await this.limitLegacyMinMax(limit, actor, factor);
} else if (hasMinLimit(limit)) { } else if (hasMinLimit(limit)) {
return await this.limitMinLegacy(limit, actor, factor); return await this.limitLegacyMinOnly(limit, actor, factor);
} else { } else {
return disabledLimitInfo; return disabledLimitInfo;
} }
} }
private async limitMaxLegacy(limit: Keyed<MaxLegacyLimit>, actor: string, factor: number): Promise<LimitInfo> { private async limitLegacyMinMax(limit: Keyed<MaxLegacyLimit>, actor: string, factor: number): Promise<LimitInfo> {
if (limit.duration === 0) return disabledLimitInfo; if (limit.duration === 0) return disabledLimitInfo;
if (limit.duration < 0) throw new Error(`Invalid rate limit ${limit.key}: duration is negative (${limit.duration})`); if (limit.duration < 0) throw new Error(`Invalid rate limit ${limit.key}: duration is negative (${limit.duration})`);
if (limit.max < 1) throw new Error(`Invalid rate limit ${limit.key}: max is less than 1 (${limit.max})`); if (limit.max < 1) throw new Error(`Invalid rate limit ${limit.key}: max is less than 1 (${limit.max})`);
@ -87,7 +87,7 @@ export class SkRateLimiterService {
return await this.limitBucket(bucketLimit, actor, factor); return await this.limitBucket(bucketLimit, actor, factor);
} }
private async limitMinLegacy(limit: Keyed<MinLegacyLimit>, actor: string, factor: number): Promise<LimitInfo> { private async limitLegacyMinOnly(limit: Keyed<MinLegacyLimit>, actor: string, factor: number): Promise<LimitInfo> {
if (limit.minInterval === 0) return disabledLimitInfo; if (limit.minInterval === 0) return disabledLimitInfo;
if (limit.minInterval < 0) throw new Error(`Invalid rate limit ${limit.key}: minInterval is negative (${limit.minInterval})`); if (limit.minInterval < 0) throw new Error(`Invalid rate limit ${limit.key}: minInterval is negative (${limit.minInterval})`);